Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize plugins #74

Closed
chapulina opened this issue Jun 10, 2020 · 3 comments · Fixed by #84
Closed

Minimize plugins #74

chapulina opened this issue Jun 10, 2020 · 3 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@chapulina
Copy link
Contributor

As we start having larger plugins, they start taking more and more real estate on the window. For example, the plotting tool (#66) and the resource spawner (gazebosim/gz-sim#31) will be too large to keep on the left panel, and too large to be overlapped on top of the 3D scene when undocked.

Some plugins could be launched on their own window using 'ign gui -s'. This should work for plotting if all the user needs are topics. But plugins like the spawner will need to be on the same process as the 3D scene. So we need a way to make large plugins more manageable.

The idea on this ticket is to let plugins be collapsed / minimized. This applies to both docked and undocked plugins.

The minimize / maximize buttons could be on the plugin toolbar next to dock / undock.

@chapulina chapulina added enhancement New feature or request help wanted Extra attention is needed labels Jun 10, 2020
@Sarath18
Copy link
Contributor

Sarath18 commented Jun 11, 2020

minimize
Does this implementation meet a few of the ticket requirements?

I tried to add a button on the title bar to expand/collapse the plugin. I set the height of the plugin card rectangle to 50 (height of the title bar) to collapse the plugin. Is this correct? (feels kind of hacky way to do it)

@chapulina
Copy link
Contributor Author

Nice, that looks great! That sounds like a valid implementation to me. I believe it also works when the plugins are docked, right?

Looking at your gif, I also think it would make it super nice to apply a NumberAnimation to the height when changing it, to make the transition smoother. See an example here:

https://github.com/ignitionrobotics/ign-gui/blob/75404e2ff46f4445a2f91b57f76033a0f6f6f2df/src/plugins/world_stats/WorldStats.qml#L123-L142

@Sarath18
Copy link
Contributor

Nice, that looks great! That sounds like a valid implementation to me.

Great!

I believe it also works when the plugins are docked, right?

Not yet, will work on that.

Looking at your gif, I also think it would make it super nice to apply a NumberAnimation to the height when changing it, to make the transition smoother.

Yes, it is snappy at the moment. I'll try to add this feature as well.

@chapulina chapulina linked a pull request Jul 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants