Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New thermal camera integration test failure for Edifice #253

Open
adlarkin opened this issue Feb 17, 2021 · 3 comments
Open

New thermal camera integration test failure for Edifice #253

adlarkin opened this issue Feb 17, 2021 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed macOS macOS support tests Broken or missing tests / testing infra

Comments

@adlarkin
Copy link
Contributor

After forward porting some changes from ign-rendering4 to main, a new integration test failure appeared for the thermal camera. More information can be found in #246.

Environment

  • OS Version: MacOS
  • Source build (commit 52c4ab0, main branch at the time of this writing)

Description

  • Expected behavior: test/integration/thermal_camera should pass on MacOS.
  • Actual behavior: test/integration/thermal_camera failed on MacOS.
  • test/integration/thermal_camera does not fail for MacOS on the ign-rendering4 branch: 4 ➡️ 5 #246 (comment)

Steps to reproduce

  1. Clone the repo: git clone https://github.com/ignitionrobotics/ign-rendering.git
  2. Complete the build so that tests are available:
cd ign-rendering
mkdir build
cd build
cmake ..
make
  1. Run the thermal camera integration test:
# the following steps assume you are already in the ign-rendering/build directory
cd bin
./INTEGRATION_thermal_camera

Output

Here is the original failure from CI in #246:

/Users/jenkins/workspace/ignition_rendering-ci-pr_any-homebrew-amd64/ign-rendering/test/integration/thermal_camera.cc:233
The difference between boxTemp and temp is 14, which exceeds boxTempRange, where
boxTemp evaluates to 310,
temp evaluates to 296, and
boxTempRange evaluates to 3.
@adlarkin adlarkin added the bug Something isn't working label Feb 17, 2021
@adlarkin adlarkin mentioned this issue Feb 17, 2021
@chapulina chapulina added the tests Broken or missing tests / testing infra label Feb 17, 2021
@adlarkin adlarkin self-assigned this Feb 17, 2021
@adlarkin
Copy link
Contributor Author

adlarkin commented Feb 17, 2021

It seems like there are related test failures in gazebosim/gz-sim#622, which should also be addressed. I'm guessing that the thermal camera behavior is different in Edifice.

@jacobperron
Copy link

Another instance of this test failure: https://build.osrfoundation.org/job/ignition_rendering-ci-ign-rendering5-homebrew-amd64/17/

I noticed many instances of the following logged error (I'm not sure if it's relevant):

[Err] [Ogre2RenderEngine.cc:467] Unable to find Ogre Plugin[/usr/local/opt/ogre2.1/lib/OGRE-2.1/RenderSystem_GL3Plus]. Rendering will not be possible.Make sure you have installed OGRE properly.

@chapulina
Copy link
Contributor

I'm guessing that the thermal camera behavior is different in Edifice.

The test has been flaky on all versions, so I don't think the issue is version-specific. Here are the histories:


https://github.com/osrf/buildfarmer/issues/224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed macOS macOS support tests Broken or missing tests / testing infra
Projects
None yet
Development

No branches or pull requests

3 participants