Added private data pointer for storage #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
|
LGTM but would defer to @mjcarroll on this one. |
mjcarroll
reviewed
Apr 22, 2024
There was a problem hiding this comment.
I'm not opposed to this, but it isn't strictly necessary.
In many places inside of Gazebo, you will find the PIMPL pattern because we are strict about maintaining ABI compatibility within a certain version. If this ABI-compatibility isn't necessary in your project's system implementation, then it is perfectly fine to use traditional class members, rather than the PIMPL pattern.
Can you add some documentation to this effect?
Comment on lines
+60
to
+63
| FullSystem::~FullSystem() | ||
| { | ||
| // Do nothing | ||
| } |
There was a problem hiding this comment.
Suggested change
| FullSystem::~FullSystem() | |
| { | |
| // Do nothing | |
| } | |
| FullSystem::~FullSystem() = default; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
The system plugin often needs to save static values to function, or store variables extracted from the SDF file. Implemented a class in
FullSystemplugin and created a variable of that class as a unique pointer (following PImpl technique).