Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert URDF files to SDF with use_parent_model_frame set to 0 #189

Closed
osrf-migration opened this issue May 24, 2018 · 4 comments
Closed
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Silvio Traversaro (Bitbucket: traversaro).


The use_parent_model_frame option was added in SDF as part of https://bitbucket.org/osrf/gazebo/issues/494/make-joint-axis-reference-frame-relative and the related PRs .

As the URDF --> SDF converted was written before that time, all the SDF generated from URDF files by gz sdf -c model.urdf > model.sdf contain the option use_parent_model_frame set to 1. It would be great if SDF could produce a URDF with the use_parent_model_frame option set to 0.

This is due to the fact that the URDF is actually converted in [1] to a SDF 1.4, and then converted to a SDF 1.6 using the SDF conversion rules.

Related issue: bulletphysics/bullet3#1707

[1] : https://github.com/osrf/sdformat/blob/master/src/parser_urdf.cc

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


This has more info that #163, so I'll mark that one as duplicate.

Here's the line of code where the sdf version is set:

https://github.com/osrf/sdformat/blob/ef889105d2512cd42999c55a1d9facecf1f348c6/src/parser_urdf.cc#L3155

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Issue #163 was marked as a duplicate of this issue.

@osrf-migration
Copy link
Author

Original comment by Silvio Traversaro (Bitbucket: traversaro).


Thanks @scpeters , I did not noticed #163.

Other relevant info:

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

this was done in pull request #575, targeted at sdf6

it was merged forward to sdformat8 and released in 8.4.0

it was already included in 9.0.0

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant