Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a comment function with annotations #610

Closed
schuchaa opened this issue Aug 10, 2021 · 3 comments
Closed

Implementation of a comment function with annotations #610

schuchaa opened this issue Aug 10, 2021 · 3 comments
Labels
feature Additional functionality workflow affects the mapping workflow
Milestone

Comments

@schuchaa
Copy link

For the creation of mappings it is useful to be able to assign comments. For example, for comments from the WebDewey Deutsch that have led to a mapping decision.

@schuchaa schuchaa added the feature Additional functionality label Aug 10, 2021
@stefandesu
Copy link
Member

As far as I can see, this should already be supported by jskos-server because it doesn't restrict the motivation property of annotations. However, there are related issues that could be addressed:

So this issue is only about the UI implementation in Cocoda. Should we allow any markup (maybe a restricted set of Markdown) or just plain text?

@nichtich
Copy link
Member

nichtich commented Aug 10, 2021

just plain text. Could also include hyperlinks (clients can detect "https?://..." URLs and provide as link).

@nichtich
Copy link
Member

nichtich commented Aug 12, 2021

Includes at least

  • show comments in mapping detail
  • indicate existing comments in mapping table (e.g. with a colored speech bubble)
  • edit form to add or delete a comment (also to modify?)

A plain comment is not enough nevertheless. What's the typical workflow?

  • Some comments are additional explanation to a mapping
  • Some comments are questions or remarks to change, add, improve... something related to the mapping. These comments should be removed after the issue has been resolved.

For the second use case comments are like GitHub issues or word processor edit suggestions, so the workflow is

  • mapping is commented by person A
  • comment is deleted ("resolved") by person B

Who should be allowed to delete/resolve comments? Any of:

  • account with rights to edit the commented mapping
  • account with rights to confirm the mapping
  • the creator of the comment

@nichtich nichtich added the workflow affects the mapping workflow label Sep 21, 2021
@stefandesu stefandesu added this to the 1.6.0 milestone Oct 21, 2021
@nichtich nichtich modified the milestones: 1.6.0, 1.7.0 Dec 10, 2021
@nichtich nichtich closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality workflow affects the mapping workflow
Projects
None yet
Development

No branches or pull requests

3 participants