Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

Don't run check again for error message #68

Open
phorsuedzie opened this issue Nov 1, 2017 · 0 comments
Open

Don't run check again for error message #68

phorsuedzie opened this issue Nov 1, 2017 · 0 comments

Comments

@phorsuedzie
Copy link

phorsuedzie commented Nov 1, 2017

The "solution" to keep check and related error message dry looks more like a workaround.

Issues:

  • The (probably expensive) check is run twice.
  • It relies on any state considered by check being identical at the time of the check and the time when getValidationErrorMessage is called. One candidate for a non-identical world state is e.g. a new Date().

Instead, the check should be able to leave check (failure) details which are provided to (e.g.) getValidationErrorMessage.

@phorsuedzie phorsuedzie changed the title Don't double-check for error message Don't run check again for error message Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant