You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
The "solution" to keep check and related error message dry looks more like a workaround.
Issues:
The (probably expensive) check is run twice.
It relies on any state considered by check being identical at the time of the check and the time when getValidationErrorMessage is called. One candidate for a non-identical world state is e.g. a new Date().
Instead, the check should be able to leave check (failure) details which are provided to (e.g.) getValidationErrorMessage.
The text was updated successfully, but these errors were encountered:
phorsuedzie
changed the title
Don't double-check for error message
Don't run check again for error message
Nov 1, 2017
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The "solution" to keep check and related error message dry looks more like a workaround.
Issues:
getValidationErrorMessage
is called. One candidate for a non-identical world state is e.g. anew Date()
.Instead, the check should be able to leave check (failure) details which are provided to (e.g.)
getValidationErrorMessage
.The text was updated successfully, but these errors were encountered: