-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbols & Punctuation Support #16
Comments
Hey @JamoCA, I am just a user of Junitdecode and not a maintainer but I stumbled over your issue that has not been answered for 3 years. So I added this test method to
After running the modified test it remains green. IMHO your bug report is invalid and Junidecode is behaving correct. p.s.: junidecode/src/main/java/net/gcardone/junidecode/X21.java Lines 109 to 120 in d479f6f
And if I am not mistaken the last one (elip) is this one:
|
I'll need to see if I can recreate the exact issue that I encountered 3 years ago and write some unit tests. I've installed a number of java updates over the years and it's possible that whatever I was encountering has been fixed as of my initial tests work without having to pre-sanitize. It was odd because Microsoft was adding cosmetic characters that looked correct, but were some alternate unicode characters. I also ran into issues where some extended IDN characters were being used to bypass filters. I'll retest soon. |
I'm not entirely sure if this is a valid bug report or not, but while pasting content from Microsoft Word to CKEditor and processing using Junidecode, I encountered a reproducible
java.lang.NullPointerException
error. I narrowed it down to a single "right single quotation mark" (U+2019) character.To prevent this error from being a show stopper, I wrote a wrapper for the Junidecode function that pre-sanitizes symbols & punctuation using the recommended mapping from NIH's Lexical Systems Group: https://lexsrv3.nlm.nih.gov/LexSysGroup/Projects/lvg/2013/docs/designDoc/UDF/unicode/NormOperations/mapSymbolToAscii.html
Here's the ColdFusion (similar to Java) user-defined function that I wrote.
https://gist.github.com/JamoCA/6f35220d47caa7fdbf75eb884ff1cec7
Is this something that should be added to Junidecode?
The text was updated successfully, but these errors were encountered: