Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC transaction output addresses #361

Open
elderapo opened this issue May 2, 2020 · 3 comments
Open

GRPC transaction output addresses #361

elderapo opened this issue May 2, 2020 · 3 comments

Comments

@elderapo
Copy link

elderapo commented May 2, 2020

Shouldn't this be an array since transaction output can be spent by multiple addresses in the case of multi-sig?

string address = 4;

@cpacia
Copy link
Contributor

cpacia commented May 2, 2020

Good question. The ExtractPkScriptAddrs does return a slice of pubkeyaddresses for a bare multisig, but does anyone use this?

It also seems to not convey much without the required number of signatures parameter along with it.

I'm also not sure this counts as an "address" as we really don't have an address format for bare multisig.

@zquestz
Copy link
Contributor

zquestz commented May 2, 2020

Perhaps we should add another field to the response for this case? That way the contract for existing apps doesn't change?

@elderapo
Copy link
Author

elderapo commented May 2, 2020

I'd say addresses should be added and address can be kept as it is for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants