Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect hover on baking info #1541

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

KevinSJ
Copy link
Contributor

@KevinSJ KevinSJ commented Mar 28, 2023

Thanks for creating this app. I really like it.

I noticed after upgrading to v10, the newly added hover for the baking time is a bit off. I think it should be removed.

Before:
screen-2023-03-28-21-40-49

After:
image

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

@a3957273
Copy link
Member

a3957273 commented Feb 3, 2024

Looks good to me, thanks for the contribution! 👍

@a3957273 a3957273 merged commit a045c4f into gchq:master Feb 3, 2024
@KevinSJ KevinSJ deleted the fix/baking-time-info branch February 3, 2024 01:15
mwalbeck pushed a commit to mwalbeck/docker-cyberchef that referenced this pull request Feb 24, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gchq/CyberChef](https://github.com/gchq/CyberChef) | minor | `v10.5.2` -> `v10.8.2` |

---

### Release Notes

<details>
<summary>gchq/CyberChef (gchq/CyberChef)</summary>

### [`v10.8.2`](https://github.com/gchq/CyberChef/releases/tag/v10.8.2)

[Compare Source](gchq/CyberChef@v10.8.1...v10.8.2)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

This release replaces v10.8.1, which had an incorrect file name.  No changes were made.

### [`v10.8.1`](gchq/CyberChef@v10.8.0...v10.8.1)

[Compare Source](gchq/CyberChef@v10.8.0...v10.8.1)

### [`v10.8.0`](https://github.com/gchq/CyberChef/releases/tag/v10.8.0)

[Compare Source](gchq/CyberChef@v10.7.0...v10.8.0)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

### [`v10.7.0`](https://github.com/gchq/CyberChef/releases/tag/v10.7.0)

[Compare Source](gchq/CyberChef@10.6.0...v10.7.0)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

### [`v10.6.0`](https://github.com/gchq/CyberChef/releases/tag/v10.6.0)

[Compare Source](gchq/CyberChef@10.6.0...10.6.0)

See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details.

### [`v10.6.0`](https://github.com/gchq/CyberChef/blob/HEAD/CHANGELOG.md#1060---2024-02-03)

[Compare Source](gchq/CyberChef@v10.5.2...10.6.0)

-   Updated 'Forensics Wiki' URLs to new domain \[[@&#8203;a3957273](https://github.com/a3957273)] | \[[#&#8203;1703](gchq/CyberChef#1703)]
-   Added 'LZNT1 Decompress' operation \[[@&#8203;0xThiebaut](https://github.com/0xThiebaut)] | \[[#&#8203;1675](gchq/CyberChef#1675)]
-   Updated 'Regex Expression' UUID matcher \[[@&#8203;cnotin](https://github.com/cnotin)] | \[[#&#8203;1678](gchq/CyberChef#1678)]
-   Removed duplicate 'hover' message within baking info \[[@&#8203;KevinSJ](https://github.com/KevinSJ)] | \[[#&#8203;1541](gchq/CyberChef#1541)]

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIwMi4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Reviewed-on: https://git.walbeck.it/mwalbeck/docker-cyberchef/pulls/280
Co-authored-by: renovate-bot <bot@walbeck.it>
Co-committed-by: renovate-bot <bot@walbeck.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants