Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrypt has incorrect output in some cases #401

Closed
bwhitn opened this issue Oct 20, 2018 · 1 comment
Closed

Scrypt has incorrect output in some cases #401

bwhitn opened this issue Oct 20, 2018 · 1 comment

Comments

@bwhitn
Copy link
Contributor

bwhitn commented Oct 20, 2018

@viturc01 mentioned in Gitter that he was not receiving matching input/output between his code and CyberChef. After reviewing the information it appears that string salt to the scrypt function may not be handled correctly as it depends on how the string is decoded. A buffer can be passed to the function and it appears to fix the issue.
@bwhitn bwhitn mentioned this issue Oct 22, 2018
Merged
@n1474335
Copy link
Member

n1474335 commented Nov 6, 2018

Great work, thanks!

@n1474335 n1474335 closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@n1474335 @bwhitn