Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert train_x, train_y and _y_variance to device in batch mode? #266

Open
bk958178 opened this issue Jun 20, 2024 · 0 comments
Open

Convert train_x, train_y and _y_variance to device in batch mode? #266

bk958178 opened this issue Jun 20, 2024 · 0 comments
Labels
question Further information is requested

Comments

@bk958178
Copy link
Contributor

What's the issue?

in BaseGPController, we have:

        if self.batch_size is None:
            self.train_x = self.train_x.to(self.device)
            self.train_y = self.train_y.to(self.device)
            self._y_variance = self._y_variance.to(self.device)

i.e., when not in batch mode, the inputs are converted to the device.

Do we need to convert these to a device when we are in batch mode?

@bk958178 bk958178 added question Further information is requested new Something yet to be discussed by development team labels Jun 20, 2024
@tp832944 tp832944 removed the new Something yet to be discussed by development team label Jul 22, 2024
@db091756 db091756 mentioned this issue Aug 19, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants