Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for passing environment variables to accumulo-env.sh #191

Open
t92549 opened this issue Sep 24, 2021 · 0 comments
Open

Add method for passing environment variables to accumulo-env.sh #191

t92549 opened this issue Sep 24, 2021 · 0 comments
Labels
enhancement Improvement to existing functionality/feature Kubernetes Issue related to the Kubernetes side of the project
Milestone

Comments

@t92549
Copy link
Contributor

t92549 commented Sep 24, 2021

Currently, one environment variable is explicitly added to the accumulo-env.sh from the tserver/statefulset.yaml:

spec:
containers:
- name: accumulo-tserver
image: {{ .Values.image.repository }}:{{ .Values.image.tag }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- tserver
env:
- name: ACCUMULO_CONF_DIR
value: {{ .Values.config.path }}

However, that file uses lots of environment variables to set a lot of things:

test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="${POLICY} -Xmx128m -Xms128m "
test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY} -Xmx128m -Xms128m"
test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="${POLICY} -Xmx64m -Xms64m"
test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="-Xmx64m -Xms64m"
test -z "$ACCUMULO_SHELL_OPTS" && export ACCUMULO_SHELL_OPTS="-Xmx128m -Xms64m"
test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true -XX:+CMSClassUnloadingEnabled"
test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="-Xmx128m -Xms64m"
test -z "${ACCUMULO_PID_DIR}" && export ACCUMULO_PID_DIR="${ACCUMULO_HOME}/run"

Therefore, it would be good if the tserver/statefulset.yaml had an option to take an abitrary number of environment variables from the values.yaml and set them.

@t92549 t92549 added enhancement Improvement to existing functionality/feature Kubernetes Issue related to the Kubernetes side of the project labels Sep 24, 2021
@t92549 t92549 added this to the v0.16.0 milestone Sep 24, 2021
@t92549 t92549 modified the milestones: v0.16.0, v0.17.0 Oct 22, 2021
@t92549 t92549 modified the milestones: v0.17.0, v1.0.0 Dec 14, 2021
@t92549 t92549 modified the milestones: v1.0.0, v2_backlog Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature Kubernetes Issue related to the Kubernetes side of the project
Projects
None yet
Development

No branches or pull requests

1 participant