Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency version management #210

Open
t92549 opened this issue Mar 10, 2022 · 1 comment
Open

Add dependency version management #210

t92549 opened this issue Mar 10, 2022 · 1 comment
Labels
automation GitHub Actions, CI/CD dependencies Updates/changes to dependencies enhancement Improvement to existing functionality/feature Kubernetes Issue related to the Kubernetes side of the project
Milestone

Comments

@t92549
Copy link
Contributor

t92549 commented Mar 10, 2022

The version numbers of the helm charts are managed automatically with a script:

version: 0.17.1 # managed version

However, the versions of all the dependencies across the Dockerfiles, docker-compose .env files, and helm charts, are not managed automatically and must be updated manually before a gaffer-docker release:

ARG BASE_IMAGE_NAME=gchq/accumulo
ARG BASE_IMAGE_TAG=1.9.3
FROM ${BUILDER_IMAGE_NAME}:${BUILDER_IMAGE_TAG} as builder
ARG GAFFER_VERSION=1.21.1
ARG GAFFER_LIBS=bitmap-library,sketches-library,time-library

GAFFER_VERSION=1.21.1
GAFFER_TOOLS_VERSION=1.21.1
ACCUMULO_VERSION=1.9.3
HADOOP_VERSION=3.2.1

image:
repository: gchq/gaffer-rest
tag: 1.21.1

Not only is this tedious for releases, requiring manual update commits, but it is also error-prone as this manual process could be done wrong, or different versions could be inconsistent with each other.

Therefore, a way of managing these versions should be added so it can be done automatically at time of release, and safely.

@t92549 t92549 added enhancement Improvement to existing functionality/feature automation GitHub Actions, CI/CD dependencies Updates/changes to dependencies labels Mar 10, 2022
@t92549 t92549 added this to the v2_backlog milestone Mar 10, 2022
This was linked to pull requests Mar 31, 2022
This was unlinked from pull requests Mar 31, 2022
@t92549
Copy link
Contributor Author

t92549 commented Mar 31, 2022

#211 ensured that the images that are built, tested and released are the ones in the docker/gaffer-pyspark-notebook/.env file, as well as automatically ensuring the helm chart versions are correct.
This is a step forward but manual commits are still required to update the versions in the Dockerfiles and docker-compose files.

@GCHQDeveloper314 GCHQDeveloper314 added the Kubernetes Issue related to the Kubernetes side of the project label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation GitHub Actions, CI/CD dependencies Updates/changes to dependencies enhancement Improvement to existing functionality/feature Kubernetes Issue related to the Kubernetes side of the project
Projects
None yet
Development

No branches or pull requests

2 participants