Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in docker-compose files #239

Open
lb324567 opened this issue Aug 2, 2022 · 1 comment
Open

Reduce duplication in docker-compose files #239

lb324567 opened this issue Aug 2, 2022 · 1 comment
Labels
Docker Issue related to the Docker side of the project enhancement Improvement to existing functionality/feature
Milestone

Comments

@lb324567
Copy link
Member

lb324567 commented Aug 2, 2022

A lot of the compose files contain the same set up for certain images. We can extend compose files to reduce this duplication, while still keeping the services the same.

It would also be to use a makefile so that simple commands can be used to run the commands for docker compose (which will be longer if we make the changes above).
Example of using makefiles for docker compose operations can be found here. (Tldr; instead of the typing docker compose -f docker-compose.yml -f docker-compose.accumulo.yml to bring up the accumulo containers the user would instead type make accumulo)

@GCHQDeveloper314 GCHQDeveloper314 added this to the post-v2.0_backlog milestone Nov 2, 2022
@GCHQDeveloper314 GCHQDeveloper314 added enhancement Improvement to existing functionality/feature Docker Issue related to the Docker side of the project labels Jul 12, 2023
@GCHQDeveloper314
Copy link
Member

I don't like the idea of introducing an extra dependency on make for doing this. But reducing duplication is a good idea. I would suggest potentially using a shell script for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Issue related to the Docker side of the project enhancement Improvement to existing functionality/feature
Projects
None yet
Development

No branches or pull requests

2 participants