Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For 3D map with restricted height, the preview does not match the actual map #15

Closed
csemrau opened this issue Mar 1, 2024 · 1 comment

Comments

@csemrau
Copy link
Contributor

csemrau commented Mar 1, 2024

This is something I noticed when playing around with the options. It does not affect me at the moment, since I'm busy building the flat map I generated.

When the 3D option is enabled with a restricted height limit, like 5, then the preview of the converted image seems to ignore the height restriction. Therefore, it does not match the map that is actually generated. The same applies to the colors shown in the survival guide image.

This is most noticeable when dither is disabled.

Here's an example.

Original image, already resized for a 1x1 map:

Converting using the full palette, 3D with height limit 5, and no dither.

Preview of converted:

In-game map after running the functions to create the map art:

I totally understand that, with a restricted height, it is impossible to use all 3 height-dependent shades of a color for every pixel.

A simple improvement would be to consider the truncated heights for the preview and survival guide, which at least provides an accurate preview of what you get.
A better improvement would be to consider the height limit during color conversion, which could lead to better fitting colors.

@gd-codes
Copy link
Owner

gd-codes commented Mar 2, 2024

Thanks for bringing this up. I was aware that the preview doesn't show the errors due to height restriction, and can add your suggested improvements in the next update of the web app.

P.S. It may be a short while till I get the free time to make & release the changes. In case anyone would like this urgently, pull requests are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants