Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost all request markdowns in 'docs/endpoints/' need to be updated #84

Open
flid0 opened this issue Jul 26, 2022 · 1 comment
Open
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@flid0
Copy link

flid0 commented Jul 26, 2022

Take any .md file in the endpoints directory and run the snippet and it will result in a 403 Forbidden.
Why? Because: 1. the 'User-Agent' header should be empty and 2. the base endpoint url should start with the www subdomain

# currently
import requests

data = {
    "secret": "Wmfd2893gb7",
    "targetAccountID": 173831
}

req = requests.post('http://boomlings.com/database/getGJUserInfo20.php', data=data)
print(req.text)
# what it should be
import requests

data = {
    "secret": "Wmfd2893gb7",
    "targetAccountID": 173831
}

req = requests.post('http://www.boomlings.com/database/getGJUserInfo20.php', data=data, headers={"User-Agent": ""})
print(req.text)

notice the www subdomain and headers argument
not a pressing issue but it isn't so good if the docs' code snippets don't work

@Wyliemaster Wyliemaster added bug Something isn't working documentation Improvements or additions to documentation labels Jul 26, 2022
@nekitdev
Copy link
Member

This is a known issue. #82 is going to address it fully and thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants