Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Quality of life improvements #22

Open
1 of 5 tasks
curusarn opened this issue Sep 12, 2023 · 0 comments
Open
1 of 5 tasks

API Quality of life improvements #22

curusarn opened this issue Sep 12, 2023 · 0 comments
Assignees
@tivvit

Comments

@curusarn
Copy link

curusarn commented Sep 12, 2023 •
edited
Loading

Fix

  • GameState.Character.Money should be a number
  • Only use ItemSlot or ItemType (We now have item.Slot field vs. ...ItemType type)
  • Unify use of Coordinates and Position and Location (in SkillUse) - for types and fields/attributes

Maybe fix

  • Dunegeonsandtrolls should be DunegeonsAndTrolls

Wishlist 🙏

  • Dunegeonsandtrolls prefixes/suffixes are annoying
@tivvit tivvit self-assigned this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivvit tivvit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tivvit @curusarn