Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port project to Godot 4 #48

Closed
JAWS81 opened this issue May 25, 2023 · 7 comments
Closed

Port project to Godot 4 #48

JAWS81 opened this issue May 25, 2023 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JAWS81
Copy link

JAWS81 commented May 25, 2023

No description provided.

@IceflowRE
Copy link

Duplicate #47.

@Zifai
Copy link

Zifai commented Nov 9, 2023

Please update

@Reneator
Copy link

I am using an old version of the outline shader and it stopped working with godot 4, i stumbled on a solution that should work with many of the shaders from this repo (mostly regarding fragment functions):

godotengine/godot#49781

TL;DR: Many of the shaders can be fixed when setting color by using a "COLOR *=" instead of "COLOR =", because it seems the values are different now.

Maybe leaving this one up so people could stumble upon this could be helpful.

@Reneator
Copy link

The tip above is mostly meant to fix the "modulate set on a canvasItem gets ignored when shader is applied" and to then also be able to draw outside the texture you might need something along the lines of:

if (color.a <= 0.0) {
  COLOR = mix(color, line_color, outline - color.a);
}
else {
  COLOR *= mix(color, line_color, outline - color.a);
}

@NathanLovato NathanLovato added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 25, 2024
@NathanLovato NathanLovato changed the title Please update to Godot 4 Port project to Godot 4 Aug 25, 2024
@NathanLovato
Copy link
Contributor

If someone would like to contribute, this would be most welcome. I won't have time to port this myself anytime soon.

@tetrapod00
Copy link
Contributor

tetrapod00 commented Sep 15, 2024

I can try porting some of these. I'd recommend choosing 4.3 as the lowest supported version, if you have any shaders that read from the depth texture, since 4.3 is the first version after Reverse-Z.

Looks like these shaders at least may be affected by the clip space changes:
https://github.com/gdquest-demos/godot-shaders/blob/master/godot/Shaders/water_3d.shader
https://github.com/gdquest-demos/godot-shaders/blob/master/godot/Shaders/force_field.shader

@NathanLovato
Copy link
Contributor

Closing in favor of #53 to help coordinate work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants