Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interconnect plugin assumes netlist to be omegaconf or something similar instead of dict #233

Open
nikosavola opened this issue Nov 15, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@nikosavola
Copy link
Member

nikosavola commented Nov 15, 2023

Describe the bug
In the interconnect plugin, we seem to assume the netlist structure is something else than what it really is.
At least to me netlist seems to be just a dict for which these attributes don't exist.

These lines try to access .x and .y which don't exist

loc = (
component_distance_scaling_x * placements[instance].x,
component_distance_scaling_y * placements[instance].y,
)

This appears something that would be catched with gdsfactory/gdsfactory#2080 easily.

@nikosavola nikosavola added the bug Something isn't working label Nov 15, 2023
@nikosavola
Copy link
Member Author

Same for the line here

info = instance.info.copy()

@joamatab
Copy link
Contributor

joamatab commented Dec 5, 2023

yes, it would be great to add some tests for it

@thomasdorch

Copy link

github-actions bot commented Feb 4, 2024

This issue is stale because it has been inactive for 60 days. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants