Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethexe: sync tx pool properly #4423

Open
techraed opened this issue Dec 24, 2024 · 0 comments
Open

ethexe: sync tx pool properly #4423

techraed opened this issue Dec 24, 2024 · 0 comments
Labels
C1-feature Feature request

Comments

@techraed
Copy link
Member

techraed commented Dec 24, 2024

❗ to be done after actual off-chain tx execution is introduced

Some key points:

  1. Tx pool must not accept any "add transaction" requests, unless fully synced.
    If node is not fully synced, new transactions must not be accepted, as their processing will result in state inconsistency. Also the problem is related to recent block hashes window - if node is in a sync state, it must be kept in mind that the window state is invalid.
  2. When syncing blocks txs propagation is performed by networking layer, so done independantly from the syncing process. It would easier to validate received by network txs and reproduce block commitments (which will include offchain transactions), if tx is gossiped along with recent blockhashes window. This data can be used to store newest txs until newest blocks aren't reached (synced)

Solution must test the case that when node is syncing, sending originally old transaction (but with a reference block hash valid against the lagged block hashes window) is denied.

@techraed techraed added the C1-feature Feature request label Dec 24, 2024
@techraed techraed changed the title ethexe: do not accept offchain txs when node is not fully synced ethexe: sync tx pool properly Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-feature Feature request
Projects
None yet
Development

No branches or pull requests

1 participant