Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 0x80 completion code for DCMI capabilities #3

Open
gebn opened this issue Jul 31, 2019 · 3 comments
Open

Handle 0x80 completion code for DCMI capabilities #3

gebn opened this issue Jul 31, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@gebn
Copy link
Owner

gebn commented Jul 31, 2019

The BMC is entitled to omit everything after the completion code (apart from the checksum), so the error should be able the non-normal completion code, not about the missing defining body code.

@gebn gebn added the bug Something isn't working label Aug 8, 2019
@gebn
Copy link
Owner Author

gebn commented Aug 9, 2019

If a non-zero completion code is returned, do we want to even attempt to decode lower layers? Probably not.

@gebn
Copy link
Owner Author

gebn commented Oct 9, 2019

Also handle RAKP completion codes - these are different (non-overlapping) from message codes. E.g. 0x01 is "insufficient resources" when creating a session, but 0xc0 is used for "node busy" in response to a command.

@gebn
Copy link
Owner Author

gebn commented Dec 8, 2019

This is now mostly fixed; the only one left is session establishment requests (non-commands). We don't currently retry these if we get an insufficient resources error. This is not the end of the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant