Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US Flag Misuse #115

Closed
D4rkCrypto opened this issue Aug 27, 2020 · 1 comment
Closed

US Flag Misuse #115

D4rkCrypto opened this issue Aug 27, 2020 · 1 comment

Comments

@D4rkCrypto
Copy link

https://github.com/geekdada/surgio/blob/4eafd735be8f5b2d0c34b28630c48b294eafa629/lib/misc/flag_cn.ts#L43

US flag here is using U+1F1FA U+1F1F2 which refers to U.S. Outlying Islands, not United States, although the flag looks the same. I suggest use U+1F1FA U+1F1F8 instead.

This issue causes conflicts with Quantumult X third-party resource parser when using addFlag option.

@geekdada
Copy link
Member

This really is the most interesting issue I've ever received. OK, a patch is coming your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants