Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify set and inline set design #11

Open
geeknoid opened this issue Dec 19, 2024 · 0 comments
Open

Simplify set and inline set design #11

geeknoid opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@geeknoid
Copy link
Owner

Right now, the sets/* and inline_sets/* types mirror the types in maps/* and inline_maps/*. It should be possible to support all the needed use scenarios for sets by implementing fewer types and leveraging generics instead. In particular:

sets/binary_search_set.rs
sets/eytzinger_search_set.rs
sets/dense_scalar_lookup_set.rs
sets/scan_set.rs
sets/ordered_scan_set.rs
sets/hash_set.rs

And the similarly-named types from inline_sets could be replaced with:

sets\hashed_set.rs
sets\ordered_set.rs
sets\scalar_set.rs
sets\string_set.rs

Accepting a generic Map<K, V> as a constructor parameter.

@geeknoid geeknoid added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant