Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] cargo-geiger fails/errors out when Cargo.toml has nightly features #181

Open
Evrey opened this issue Jan 26, 2021 · 3 comments
Open
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@Evrey
Copy link

Evrey commented Jan 26, 2021

To be precise, my Cargo.toml has cargo-features = ["strip"] to strip the symbol table in release builds. The TOML parser in cargo-geiger rejects this, assuming all Cargo.tomls to be stable only.

Here are my suggestions on how to solve this problem:

  • Keep up with nightly and make the parser understand and accept nightly cargo features.
  • Don't keep up with nightly and instead make the parser ignore unknown settings, assuming they are valid nightly things.
@anderejd
Copy link
Contributor

anderejd commented Jan 30, 2021

For this specific problem, it's possible that this will be solved by upgrading our old cargo crate dependency (in progress).

I know next to nothing about nightly Rust since I don't use it due to its experimental and unstable nature, but if someone wants to add support for and maintain support for nightly that would be most welcome. To be clear, I don't have any philosophical problem with nightly Rust, it's a matter of resources (time).

@anderejd
Copy link
Contributor

Upgrading cargo is in the works as part of #183.

@jullanggit
Copy link

Same issue here with the unstable.gc and unstable.gitoxide fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants