-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation component #249
Comments
Can you give more examples or other similar components? (Nav components are really what we lack, I am inverstigating such components.) |
Most nav are similar but there is different complexity. Not sure this is what you are looking for but lib using tailwind has some good nav components. Bootstrap, antd, etc all have example of nav design but most of them are not doing the mobile nav as a hamburger menu apparently ( maybe too complex to implement and too specific for each site/app). something quite simple like tailblock nav in the header section could be a good start. or the one in tailwind ui : here my company paid for it and there are good ones which basically on a mobile create a hamburger menu. |
A good start could be to recreate the Vercel Navigation, it's a combination of an a and with a 2 line hamburger on mobile. somehow make tabs work with routing without users having to implement the routing manual maybe. |
This component looks great, but they're hard to abstract. They are more like an abstraction based on business logic, not the basic component unit. (In short, the granularity is too large) For example,
So, I don't think we should leave everything to the component library, maybe a collection repo named |
So, my thoughts are as follows:
|
I like the idea of a repo with example of complex system, like Navigation headers, etc like what tailblock or tailwind ui are doing works great and let you adapt to your use case. |
I add |
For the repo, you think it should be part of zeit-ui org. or a completely separate repo? |
@wcastand |
i was mostly looking for how you want to handle it :) Also don't really want to maintain it by myself mostly because like i said, not sure what should be in it x). Most of it is already in the current website/docs. Could it make more sense to add a section to the curent website with those What do you think? |
Agreed with your point, but I have some considerations: For me, I want to differentiate between components lib and best practices. for example,
Or it's more appropriate to call them Reference sites: |
Transfer to #262 , If anyone wants to discuss it, please reopen it. |
Feature request 🚀
i couldn't find a navigation component or example. A Navbar with eventually some mobile design would be nice or an example to show how to use what's already there to do it with next.js or something like react-router maybe or "vanilla".
Expected:
Examples:
Programme:
Others:
The text was updated successfully, but these errors were encountered: