Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse Best Practices improvement #273

Closed
juanhelbert opened this issue Jun 12, 2020 · 1 comment
Closed

Lighthouse Best Practices improvement #273

juanhelbert opened this issue Jun 12, 2020 · 1 comment

Comments

@juanhelbert
Copy link

Feature request 🚀

It would be nice to have a rel prop on Image.Browser.Props where you can define a rel="noopener" or rel="noreferrer" to avoid Lighthouse's best practice errors.

Example:

It would be great to do something like this:
image

but avoiding the Lighthouse's error Add rel="noopener" or rel="noreferrer" to any external...

image

Maybe with something like this:

type = 'noopener' | 'noreferrer' 

<Image.Browser url="..." rel={type} >
  <Image ... />
</Image.Browser>

or doing it by default, because the Image.Browser has a

<a target="_blank" />
@unix
Copy link
Member

unix commented Jun 12, 2020

The latest version(pre-release) has been outed: (v1.7.0-canary.5)

  • Image.Browser now supports all attributes from AnchorElement.

document of canary branch

@unix unix closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants