Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableBackdropClick not working when there is no Modal.Action element #526

Closed
dawiddyd opened this issue Apr 29, 2021 · 1 comment
Closed

disableBackdropClick not working when there is no Modal.Action element #526

dawiddyd opened this issue Apr 29, 2021 · 1 comment
Assignees
@unix
Labels
type: bug Something isn't working

Comments

@dawiddyd
Copy link

Bug report 🐞

disableBackdropClick prop not working when there is no Modal.Action element.

Version & Environment

  • Version of browser - Chrome 90.0.4430.93
  • Version of geist-ui/react - 2.1.0-canary.2

Expected Behaviour

Modal shouldn't close on backdrop click when no Modal.Action elements.

Actual results (or Errors)

The modal is closing.
@unix unix self-assigned this May 3, 2021
@unix unix added the type: bug Something isn't working label May 3, 2021
@unix unix mentioned this issue May 3, 2021
Merged
2 tasks
@unix
Copy link
Member

unix commented May 3, 2021

This is actually a feature that disables the user from ever displaying popups. This doesn't look good now and may confuse developers.
I removed this feature in #532 to ensure it meets developer expectations, this change involves a change in behavior as will be released in the next version.

@unix unix closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unix unix

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unix @dawiddyd