Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: extend uplift to support config validation #105

Closed
1 task done
ga-paul-t opened this issue Mar 4, 2022 · 2 comments · Fixed by #324
Closed
1 task done

[Feature]: extend uplift to support config validation #105

ga-paul-t opened this issue Mar 4, 2022 · 2 comments · Fixed by #324
Assignees
Labels
enhancement New feature or request pinned Prevent the issue from being automatically closed
Milestone

Comments

@ga-paul-t
Copy link
Collaborator

Describe your feature

Provide a way for the uplift config to be validated ahead of time. This will help to ensure a smoother adoption of uplift for new users.

Your potential solution

Extend the existing list of uplift commands to include a config option:

uplift config check

Any additional information?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ga-paul-t ga-paul-t added enhancement New feature or request triage Issue has been added to our triage list labels Mar 4, 2022
@ga-paul-t ga-paul-t self-assigned this Mar 4, 2022
@ga-paul-t ga-paul-t added the pinned Prevent the issue from being automatically closed label Mar 4, 2022
@ga-paul-t ga-paul-t removed the triage Issue has been added to our triage list label May 23, 2022
@ga-paul-t ga-paul-t added this to the v2.22.0 milestone Jan 20, 2023
@ga-paul-t
Copy link
Collaborator Author

Propose that the command should be:

uplift check

By default, uplift will load in a config file from the current working directory, using the existing file naming conventions. The --config-dir flag can be used to specify an alternative location

@ga-paul-t
Copy link
Collaborator Author

Validate the config using: https://github.com/go-playground/validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Prevent the issue from being automatically closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant