feat: remove deprecated BEGIN_SESSION and END_SESSION events

gemini-testing · Nov 2, 2017 · 2c22d1d · 2c22d1d
1 parent d06a913
commit 2c22d1d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 39 deletions.
diff --git a/lib/constants/events.js b/lib/constants/events.js
@@ -9,9 +9,6 @@ module.exports = {
     BEGIN: 'begin',
     END: 'end',
 
-    BEGIN_SESSION: 'beginSession', // Deprecated, will be removed in the next major version - 5.0.0
-    END_SESSION: 'endSession', // Deprecated, will be removed in the next major version - 5.0.0
-
     RETRY: 'retry',
 
     START_BROWSER: 'startBrowser',

diff --git a/lib/runner/index.js b/lib/runner/index.js
@@ -58,13 +58,10 @@ module.exports = class TestsRunner extends Runner {
     }
 
     _runTests(suiteCollection) {
-        this.emit(Events.BEGIN_SESSION);
-
         return _(this._getBrowsersToRun())
             .map((browserId) => this._runTestsInBrowser(suiteCollection, browserId))
             .thru(promiseUtils.waitForResults)
-            .value()
-            .finally(() => this.emit(Events.END_SESSION));
+            .value();
     }
 
     _getBrowsersToRun() {

diff --git a/test/unit/gemini.js b/test/unit/gemini.js
@@ -79,9 +79,6 @@ describe('gemini', () => {
         Events.BEGIN,
         Events.END,
 
-        Events.BEGIN_SESSION,
-        Events.END_SESSION,
-
         Events.RETRY,
 
         Events.START_BROWSER,

diff --git a/test/unit/runner/index.js b/test/unit/runner/index.js
@@ -196,15 +196,6 @@ describe('runner', () => {
                 return run(runner).then(() => assert.callOrder(stateProcessor.prepare, BrowserRunner.prototype.run));
             });
 
-            it('should emit "BEGIN_SESSION" before running of tests', () => {
-                const runner = createRunner();
-                const onBeginSession = sinon.spy().named('onBeginSession');
-
-                runner.on(Events.BEGIN_SESSION, onBeginSession);
-
-                return run(runner).then(() => assert.calledOnce(onBeginSession));
-            });
-
             it('should create all browser runners', () => {
                 pool.create.returns('some-pool');
 
@@ -298,26 +289,6 @@ describe('runner', () => {
                 return assert.isRejected(run(runner), /first-runner/);
             });
 
-            it('should emit "END_SESSION" event after running of tests', () => {
-                const runner = createRunner();
-                const onEndSession = sinon.spy().named('onEndSession');
-
-                runner.on(Events.END_SESSION, onEndSession);
-
-                return run(runner).then(() => assert.callOrder(BrowserRunner.prototype.run, onEndSession));
-            });
-
-            it('should unconditionally emit "END_SESSION" event even if running of tests was rejected', () => {
-                const runner = createRunner();
-                const onEndSession = sinon.spy().named('onEndSession');
-
-                runner.on(Events.END_SESSION, onEndSession);
-
-                BrowserRunner.prototype.run.returns(q.reject());
-
-                return run(runner).catch(() => assert.calledOnce(onEndSession));
-            });
-
             it('should collect coverage', () => {
                 const runner = createRunner({config: stubConfig({isCoverageEnabled: true})});