Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set surface info not take effect in method add_surface_points #813

Closed
llcat opened this issue Jul 12, 2023 · 3 comments
Closed

set surface info not take effect in method add_surface_points #813

llcat opened this issue Jul 12, 2023 · 3 comments
Assignees
Labels

Comments

@llcat
Copy link

llcat commented Jul 12, 2023

Describe the bug
set surface info not take effect in method add_surface_points

To Reproduce
Provide detailed steps to reproduce the behavior:

  1. use getting started code
# Importing GemPy
import gempy as gp

geo_model = gp.create_model('Model1')
geo_model = gp.init_data(geo_model, extent=[0, 791, 0, 200, -582, 0], resolution=[100, 10, 100])

gp.set_interpolator(geo_model, verbose=[])

geo_model.set_default_surfaces()

geo_model.add_surface_points(X=223, Y=0.01, Z=-94, surface='surface1')
geo_model.add_surface_points(X=458, Y=0, Z=-107, surface='surface1')
geo_model.add_surface_points(X=612, Y=0, Z=-14, surface='surface1')
geo_model.add_orientations(X=350, Y=0, Z=-300, surface='surface1', pole_vector=(0, 0, 1))

geo_model.add_surface_points(X=225, Y=1, Z=-269, surface='surface2')
geo_model.add_surface_points(X=459, Y=1, Z=-279, surface='surface2')

gp.compute_model(geo_model)

# Plot in 2D
gp.plot_2d(geo_model, cell_number=5, legend='force')
# Plot in 3D
# gp.plot_3d(geo_model)

Expected behavior
the points in surface2 show correct info

Screenshots
points at surface2 still show surface1 color
image
image

Desktop (please complete the following information):

  • OS: (Win 11)
  • GemPy Version
    2.3.0
  • Jupyter Version (if applicable)

Additional context
Add any other context about the problem here.

@Japhiolite Japhiolite added the bug label Aug 11, 2023
@Japhiolite Japhiolite self-assigned this Aug 11, 2023
@Japhiolite
Copy link
Collaborator

Hi @llcat
thanks for submitting this bug. We'll take a look into it asap. Stay tuned

@Japhiolite
Copy link
Collaborator

Should be fixed in the new released version 2.3.1 on pip and here as release.

@llcat
Copy link
Author

llcat commented Aug 15, 2023

👏 👏 👏 great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants