Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer python versions #155

Open
JoaoFelipe opened this issue Jun 5, 2024 · 1 comment
Open

Support newer python versions #155

JoaoFelipe opened this issue Jun 5, 2024 · 1 comment
Labels

Comments

@JoaoFelipe
Copy link
Contributor

We need to update noworkflow to support newer Python version. I'm creating this issues to document what we need to fix on noworkflow for that.

@JoaoFelipe
Copy link
Contributor Author

Before Python 3.9, Subscript was defined as:

Subscript(expr value, slice slice, expr_context ctx)

and slice was defined as

slice = Slice(expr? lower, expr? upper, expr? step)
          | ExtSlice(slice* dims)
          | Index(expr value)

Now, subscript accepts an expression as slice:

Subscript(expr value, expr slice, expr_context ctx)

The Index and ExtSlice nodes were removed, and Slice became an expression.
I don't think we have a special logic for Index in noWorkflow, so we don't need to change anything about that. But we may need to change what we had for ExtSlice and for Slice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant