Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize configuration in a config file #40

Open
3 tasks
j6k4m8 opened this issue Jul 25, 2020 · 1 comment
Open
3 tasks

Centralize configuration in a config file #40

j6k4m8 opened this issue Jul 25, 2020 · 1 comment
Assignees
Labels
code quality Something needs to be reviewed, tested, or refactored enhancement New feature or request

Comments

@j6k4m8
Copy link
Member

j6k4m8 commented Jul 25, 2020

we should have a single js config file that includes the root URL for the API (among other global config things) which open-source forks might want to change. our default should be https://api.biascorrect.org, but this should be easily swappable in a single place in the repo.

Plan (14 points)

  • Find/read/evaluate/do a tutorial on how to do this (2 dev * 3 points = 6 points)
  • Make a plan with @j6k4m8 or @ProfJanetDavis (2 dev * 1 point = 2 points)
  • Follow the plan (2 dev * 3 points = 6 points)
@j6k4m8
Copy link
Member Author

j6k4m8 commented Jul 28, 2020

I'd recommend at least the following:

{
    "API_BASE_URL":            "https://api.biascorrect.org",
    "GOOGLE_ANALYTICS_ID":     "ga-####"
}

in something like config.production.json, where we might also have something like config.test.json with http://localhost:5000 instead.

See discussion at #43 for details.

@ProfJanetDavis ProfJanetDavis changed the title centralize config Centralize configuration in a config file Aug 6, 2020
@ProfJanetDavis ProfJanetDavis added code quality Something needs to be reviewed, tested, or refactored enhancement New feature or request labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Something needs to be reviewed, tested, or refactored enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants