Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Rhea mapping 19669 , multiple false positives, large number of false postives #5492

Open
ValWood opened this issue Oct 27, 2024 · 8 comments

Comments

@ValWood
Copy link
Contributor

ValWood commented Oct 27, 2024

GO:1990606 membrane scission GTPase motor activity 8

guf1 |   | IEA with 19669 | GO_REF:0000116
ria1 |   | IEA with 19669 | GO_REF:0000116
sar1 |   | IEA with 19669 | GO_REF:0000116
tif213 |   | IEA with 19669 | GO_REF:0000116
tif52 |   | IEA with 19669 | GO_REF:0000116

These seem to be false positives
SPBC31F10.06c | sar1 | ADP-ribosylation factor Sar1
SPCC553.08c | ria1 | GTPase Ria1
SPAC1B3.04c | guf1 | mitochondrial elongation factor GTPase Guf1
SPBC17G9.09 | tif213 | translation initiation factor eIF2 gamma subunit
SPAC56F8.03 | tif52 | translation initiation factor eIF5B Tif52

@ValWood ValWood changed the title Problem with Rhea mapping 19669 , multiple false positives Problem with Rhea mapping 19669 , multiple false positives, large number of false postives Oct 27, 2024
@pgaudet
Copy link
Contributor

pgaudet commented Oct 28, 2024

@ValWood

This is a broadMatch issue. We need the export to be fixed.... no point reporting these while the export is still not doing what we need it to.

I made this high priority.

@balhoff

@ValWood
Copy link
Contributor Author

ValWood commented Oct 28, 2024

Yep that would be good to fix with high priority . It's causing a lot of misannotations.

I had to filter over 400 incorrect IEAs for Pombe just from these few tickets! (Although these were the only problems I spotted, most of the rest are OK—or at least don't create tens of annotations.
I checked every mapping with >4 propagated annotation.

@balhoff
Copy link
Member

balhoff commented Oct 28, 2024

Filtering broad matches is done now and should appear in snapshot soon.

@ValWood
Copy link
Contributor Author

ValWood commented Oct 28, 2024

Awsome, thanks!

@ValWood
Copy link
Contributor Author

ValWood commented Nov 5, 2024

Does this affect EC mappings as well? I am seeing multiple EC mapping errors. Should I report those?

@pgaudet
Copy link
Contributor

pgaudet commented Nov 5, 2024

yes, EC is also affected - mapping types were being ignored on export, both in the .obo ontology files and in the mappings files (https://release.geneontology.org/2024-09-08/ontology/external2go/index.html)

Which one are you using?

Anyways, this should be fixed very soon.

Thanks, Pascale

@ValWood
Copy link
Contributor Author

ValWood commented Nov 5, 2024

We don't make the IEA annotations ourselves we get them from GOA, so will need to wait for the fixes to filter through

the ones I just spotted are lots of mappings to different polymerases from
https://www.pombase.org/gene/SPBC28F2.12 rpb1

@pgaudet
Copy link
Contributor

pgaudet commented Nov 5, 2024

OK. It should be fixed soon ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants