Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[advice] Make fzf more robust #16

Closed
Freed-Wu opened this issue May 2, 2022 · 4 comments
Closed

[advice] Make fzf more robust #16

Freed-Wu opened this issue May 2, 2022 · 4 comments
Assignees

Comments

@Freed-Wu
Copy link

Freed-Wu commented May 2, 2022

I advice change 12 fzfs to fzf -d' 's. Because fzf will be affected by $FZF_DEFAULT_OPT. If user use -d: or other -d, it will make fzf work abnormally.

Thanks.

@gennaro-tedesco gennaro-tedesco self-assigned this Aug 9, 2022
@gennaro-tedesco
Copy link
Owner

Sorry for the long wait in responding to this issue, and thank you for the recommendation: definitely a good idea. I will work on it in the next release :)

@gennaro-tedesco
Copy link
Owner

This PR addresses the issue: would you be so kind to help me test it to make sure there are no particular corner cases where the changes may instead behave otherwise? Ideally you could clone the repository and install the local branch

gh repo clone gennaro-tedesco/gh-f
git checkout fzf_robust
gh extension remove f
gh extension install .

and use it off: so far it seems all is good, but four eyes are better than two!

@Freed-Wu
Copy link
Author

Thanks. I have used this version, and since now I haven't found any incorrect behaviour.

@gennaro-tedesco
Copy link
Owner

Released in v0.3.3. Just gh extension upgrade f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants