Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable system-llvm for rust-1.18 #270

Closed
ambasta opened this issue Jun 19, 2017 · 9 comments
Closed

Enable system-llvm for rust-1.18 #270

ambasta opened this issue Jun 19, 2017 · 9 comments

Comments

@ambasta
Copy link

ambasta commented Jun 19, 2017

As per #37609, llvm 4 support has been merged into rust. It would be great to try out system-llvm with rust-1.18

@cnd
Copy link
Contributor

cnd commented Jun 19, 2017

@ambasta so far it's still being contributors driven 👍

@cnd
Copy link
Contributor

cnd commented Jun 26, 2017

good idea will be to try stuff from here https://github.com/smaeul/portage-overlay

@ambasta
Copy link
Author

ambasta commented Jun 28, 2017

Well, that didn't work, so I spliced the ebuild here and in smaeul to https://github.com/ambasta/ambasta/blob/master/dev-lang/rust/rust-1.18.0.ebuild

Seems to work for me, though it does download the stage0 during build

@cnd
Copy link
Contributor

cnd commented Jun 28, 2017

@ambasta there are few things: use cargo or cargo-bin in PDEPEND add LLVM_MAX_SLOT (and maybe MIN), test if cargo builds fine with it, convert all spaces into tabs. https://github.com/ambasta/ambasta/blob/master/dev-lang/rust/rust-1.18.0.ebuild#L71 - this looks unneeded and maybe some other stage0 variables
https://github.com/ambasta/ambasta/blob/master/dev-lang/rust/rust-1.18.0.ebuild#L151 - rust-lldb should be added there
and maybe here too: https://github.com/ambasta/ambasta/blob/master/dev-lang/rust/rust-1.18.0.ebuild#L140
https://github.com/ambasta/ambasta/blob/master/dev-lang/rust/rust-1.18.0.ebuild#L86 - this variable is better be called llvm-prefix and ${EPREFIX} is no needed there I think

@ambasta
Copy link
Author

ambasta commented Jun 28, 2017

@mpkh I removed the tabs before cat because I wanted to avoid tabs all together..

Will incorporate all the other recommendations :)

@cnd
Copy link
Contributor

cnd commented Jun 28, 2017

@amadio repoman (ebuild QA checker) is strongly against spaces in ebuild syntax

@ambasta
Copy link
Author

ambasta commented Jun 28, 2017

You're right.. since my vim config automatically switches b/w tab and space mode(default space unless file has tabs), I'd assumed that I'd been using spaces all this time :(

@necrose99
Copy link
Contributor

llvm-alt-0.5.0.ebuild.txt

cargo-ebuild , a number of rust add-ons for llvm in rust.. via cargo crates...

@cnd
Copy link
Contributor

cnd commented Jan 26, 2018

obsolete

@cnd cnd closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants