Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis builds fail for tip version - use stable instead #66

Closed
pawelprazak opened this issue Feb 16, 2018 · 7 comments
Closed

Travis builds fail for tip version - use stable instead #66

pawelprazak opened this issue Feb 16, 2018 · 7 comments

Comments

@pawelprazak
Copy link
Contributor

All recent builds fail in a weird way:

$ staticcheck $(go list ./... | grep -v vendor)
/home/travis/gopath/src/github.com/jessfraz/reg/vendor/github.com/docker/docker/registry/session.go:572:32: cannot use tarsumLayer (variable of type github.com/jessfraz/reg/vendor/github.com/docker/docker/pkg/tarsum.TarSum) as io.Reader value in argument to io.TeeReader: missing method Read
couldn't load packages due to errors: github.com/jessfraz/reg/vendor/github.com/docker/docker/registry
The command "staticcheck $(go list ./... | grep -v vendor)" exited with 1.

I was not able to reproduce it locally. But from what I can gather, tip == master:
travis-ci/gimme#110
travis-ci/travis-build@b114b18#diff-fe52d3b67e8fe283d39c20d2b87d82f8

Moreover, the docs doesn't mention tip at all, there's only 1.x and master.

So IMHO something like this would be better / more stable, e.g.:

...
go:
  - 1.x
  - master
matrix:
  allow_failures:
    - go: master
  fast_finish: true
...
    on:
      go: 1.x
...
@pawelprazak
Copy link
Contributor Author

I've reproduced it locally:

docker run --rm -v "$PWD":/go/src/github.com/jessfraz/reg --workdir /go/src/github.com/jessfraz/reg -v /tmp:/tmp reg-gimme:latest make init staticcheck
go version devel +07f0f09563 Fri Feb 16 15:37:57 2018 +0000 linux/amd64
+ init
go get -u honnef.co/go/tools/cmd/staticcheck
+ staticcheck
/go/src/github.com/jessfraz/reg/vendor/github.com/docker/docker/registry/session.go:572:32: cannot use tarsumLayer (variable of type github.com/jessfraz/reg/vendor/github.com/docker/docker/pkg/tarsum.TarSum) as io.Reader value in argument to io.TeeReader: missing method Read
couldn't load packages due to errors: github.com/jessfraz/reg/vendor/github.com/docker/docker/registry

With a custom gimme image set to tip version.

@pawelprazak
Copy link
Contributor Author

pawelprazak commented Feb 16, 2018

I've tried the 1.x version with mixed results: https://travis-ci.org/pawelprazak/reg/jobs/342529887

Deployment hasn't triggered:

Skipping a deployment with the releases provider because this is not on the required runtime

@pawelprazak
Copy link
Contributor Author

Using the undocumented stable version (resolved to go1.9.4) gives the expected result:
https://travis-ci.org/pawelprazak/reg/jobs/342534715

@pawelprazak
Copy link
Contributor Author

@jessfraz any thoughts on this?

@pawelprazak pawelprazak changed the title Travis builds fail for tip version - use 1.x instead Travis builds fail for tip version - use stable instead Feb 17, 2018
@jessfraz
Copy link
Collaborator

Thanks for going into so much detail, ya this happening on like 30 of my projects because I share the same travis config. I will fix

@jessfraz
Copy link
Collaborator

fixed by 533d292

@pawelprazak
Copy link
Contributor Author

I hate when CI is red ;) also reverse-engineering is so much fun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants