Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geocoder.ca defaults to http and puts auth in query string #52

Open
adjenks opened this issue Jul 30, 2021 · 0 comments
Open

geocoder.ca defaults to http and puts auth in query string #52

adjenks opened this issue Jul 30, 2021 · 0 comments

Comments

@adjenks
Copy link

adjenks commented Jul 30, 2021

Just some suggestions about security.

Providers should default to using https when possible. It's better to start secure and let the user choose to downgrade. The geocoder provider defaults to http.

Providers should avoid putting authentication parameters in query strings because they are more likely to get logged somewhere, geocoder.ca accepts post requests, so this would be possible, but the provider code currently uses a query string parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant