Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading 0 from zip code is not included/stripped #132

Open
sbernheim4 opened this issue Aug 30, 2017 · 6 comments
Open

Leading 0 from zip code is not included/stripped #132

sbernheim4 opened this issue Aug 30, 2017 · 6 comments

Comments

@sbernheim4
Copy link

I am in a zip code that begins with a 0 but the zip code I get back from using this does not include the 0. For example, if the zip code is 02345 then I only get back 2345 with the first 0 missing.

@bluesmoon
Copy link
Collaborator

Yeah, this is a known issue. See #122 (comment)

Do you want to take a stab at fixing it?

@sbernheim4
Copy link
Author

sbernheim4 commented Aug 30, 2017

Thanks and yeah I can try, should I just fork it and then submit a PR if I can get it to work?

@bluesmoon
Copy link
Collaborator

yes, that would be awesome.

@hotdang-ca
Copy link

Please review above PR.
My only concern is the return of a string, rather than a number; if backwards-compatibility requires zip to be a number, I could provide an optional property to grab zipAsString, or something...

@Download
Copy link

Zip codes as Number?

My zip code (Netherlands):

6512 BM

How will you turn that into Number? Or is this a code branch specifically for US zip codes?

@bluesmoon
Copy link
Collaborator

bluesmoon commented Sep 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants