New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect commit_id as parameter and as pre-condition #18

Open

2 tasks

boly38 opened this issue Oct 18, 2018 · 1 comment

Labels

enhancement test

Member

boly38 commented Oct 18, 2018 •

edited

Loading

commit_id should be set as build environment variable
for each robot scenario, commit_id should be a requirement

Note about implementation:

should use "before test" to do that
add dedicated function to check 'commit_id' in the footer
should retrieve geokrety-website average "deploy" steps duration
this requirement show allow a given delay (eg. average "deploy" steps duration +20%)
this requirement show report a clear assert message, ex.:

wrong version to test, expected commit_id=${commit_id} in the footer

boly38 added enhancement test labels

Member Author

boly38 commented Oct 8, 2019

This point should be adressed as soon as possible in the test pipeline, so geokrety/geokrety-website#531 must be the good way to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment