Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to Docs? #170

Open
lapp0 opened this issue Feb 9, 2021 · 4 comments
Open

Contributing to Docs? #170

lapp0 opened this issue Feb 9, 2021 · 4 comments

Comments

@lapp0
Copy link

lapp0 commented Feb 9, 2021

Hi,

I'd like to contribute a small section to the docs that I found helpful (using requests_cache so tiles don't take super long to load each run).

I don't see a repo for the documentation, nor do I see anything beyond the main page of https://contextily.readthedocs.io/ in the contextily repo. Are the docs auto-generated from github anywhere? Is there any documentation on how to contribute to contextily's docs?

Thanks!

@jorisvandenbossche
Copy link
Member

That would be very welcome!

The actual content of the docs lives in the notebooks directory: https://github.com/geopandas/contextily/tree/master/notebooks (when building the docs, those are copied into the docs/ directory). We should probably add a README to the /docs directory to mention this.

Note that we have a set_cache_dir function that also helps with caching across python sessions (but this is also not included in the docs .. It was added here: #106)

@lapp0
Copy link
Author

lapp0 commented Feb 10, 2021

Thanks. I have a second question. I see _providers.py is autogenerated. Would it be within the scope of this project to create a new module to allow for the inclusion of hardcoded USGS map servers?

https://basemap.nationalmap.gov/arcgis/rest/services

@jorisvandenbossche
Copy link
Member

The first option is ideally to check if they can be added to leaflet-providers (from which our list is autogenerated), and if that's not possible, we can indeed have another script that adds some other hard-coded ones to the generated _providers.py file.

Now, I was quickly checking leaflet-providers, and it seems someone recently added some USGS providers: leaflet-extras/leaflet-providers#367
Could you check if that are the services that you are interested in?

If so, we should re-generate the _providers.py with the latest leaflet-providers version to include those new (there will be other useful changes as well, probably)

@abubelinha
Copy link

@lapp0 can you share a example code of how you are using in contextily the arcgis servers in your 2nd question?

Sorry about my ignorance but this is the only contextily issue where I found an arcgis link.
So I wonder if they may use a similar syntax as the servers I commented in geopandas/xyzservices#41 (comment)

Thanks
@abubelinha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants