Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.7.0 #316

Closed
brendan-ward opened this issue Oct 24, 2023 · 7 comments
Closed

Release version 0.7.0 #316

brendan-ward opened this issue Oct 24, 2023 · 7 comments
Milestone

Comments

@brendan-ward
Copy link
Member

Outstanding PRs:

@brendan-ward brendan-ward added this to the 0.7.0 milestone Oct 24, 2023
@theroggy
Copy link
Member

theroggy commented Oct 25, 2023

For #306, enabling the sql tests lead to a bug being found, so it would be good if it can make it into version 0.7 still.

I did fix the bug in the PR already, but it is still marked as draft because I still needed to add an optimization to use the fast code path for newer gdal versions as a gdal bug was solved to make this possible. However, it is a small change to make, so it shouldn 't take long.

@jorisvandenbossche
Copy link
Member

What's the bug exactly? Because right now the skip_features for Arrow is only enabled for GDAL >= 3.8, I think? (and in GDAL 3.8 this bug will be fixed?)

I would say that both PRs are not super critical to get in for 0.7 (but of course if they are ready, let's merge them), and would prefer to do a release shortly.

@theroggy
Copy link
Member

What's the bug exactly? Because right now the skip_features for Arrow is only enabled for GDAL >= 3.8, I think? (and in GDAL 3.8 this bug will be fixed?)

On second thought you are right:

  • for gdal < 3.8 the filtering is done in pyogrio in the code on main so the result is correct.
  • for gdal >= 3.8 the filtering is done in gdal... but there the bug has been fixed now, so it is also correct.

I would say that both PRs are not super critical to get in for 0.7 (but of course if they are ready, let's merge them), and would prefer to do a release shortly.

I agree.

@brendan-ward
Copy link
Member Author

I moved both #304 (we're not yet decided on the API/approach) and #306 (hard to test without recent version GDAL including fixes) to a later milestone, so we're ready to proceed with this version.

I'll try to push the release momentarily.

@brendan-ward
Copy link
Member Author

Release is out: https://github.com/geopandas/pyogrio/releases/tag/v0.7.0
wheels on PyPI: https://pypi.org/project/pyogrio/#files

@jorisvandenbossche
Copy link
Member

One problem that turned up on conda-forge/pyogrio-feedstock#38: the PR #285 added a usage of from packaging.version import Version in non-test code, and so essentially packaging has become a hard dependency of pyogrio, while it is not listed in our dependencies.

So we should either add it as dependency, or remove that one usage (I think we could also easily remove it, it's just checking that shapely > 2, so that can be done manually as well)

@jorisvandenbossche
Copy link
Member

See #318 for avoiding usage of it. Of course, simply adding it to

install_requires=["certifi", "numpy"],

is also a trivial change, and should be no problem (for example, also geopandas depends on it, so most users will already have it anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants