feat: add TypeScript definitions

[friedjoff]

And bundle with esbuild.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
openlayers-editor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2023 7:37am

[oterral]

Nice . I think you can get rid fo webpacks packages using the basic serve functionnality of esbuild to replace webpack-dev-server.

esbuild build/index.js --bundle --outfile=build/bundle.js --loader:.svg=text --minify --sourcemap --watch --serve

[friedjoff]

Nice . I think you can get rid fo webpacks packages using the basic serve functionnality of esbuild to replace webpack-dev-server.

esbuild build/index.js --bundle --outfile=build/bundle.js --loader:.svg=text --minify --sourcemap --watch --serve

Good idea, I've tried, but Cypress doesn't seem happy yet.

[oterral]

I will leave browserslist, because it's important in mapset .... or maybe not something to test.

[friedjoff]

Do you know how to test this?

[oterral]

I will test and will addd them again if needed

[oterral]

Good idea, I've tried, but Cypress doesn't seem happy yet.

There is always someone unhappy with progress :-D

[oterral]

@friedjoff for the node bug on test. Upgrade the .nvmrc file and use it in the action like this:

https://github.com/geops/trafimage-maps/blob/master/.github/workflows/cypress-chrome.yml#L12

[friedjoff]

for the node bug on test. Upgrade the .nvmrc file and use it in the action like this:

For apps I agree with using something like .nvmrc, but for open source libraries we should not pin to a specific Node.js version to catch incompatibilities with different versions. I've changed the matrix strategy for our Cypress GitHub Action to use the oldest maintained LTS release and the latest stable release to make sure we support a sensible range of Node.js releases.

[oterral]

but for open source libraries we should not pin to a specific Node.js version to catch incompatibilities with different versions

If you pin everybody will use the same node version so no more problem. Dependency like node-canvas are already node version dependent. The only problem I had with node version is when they were not pinned so CI didn't use the good node version and test failed for a month, and nobody care.

[oterral]

Very nice thanks