Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRS query parameter support for EDR #1104

Closed
petergarnaes opened this issue Jan 15, 2023 · 3 comments
Closed

CRS query parameter support for EDR #1104

petergarnaes opened this issue Jan 15, 2023 · 3 comments
Labels
enhancement New feature or request stale Issue marked stale by stale-bot
Milestone

Comments

@petergarnaes
Copy link
Contributor

Section 8.2.1.4 of the EDR specification v. 1.0.1 (which is the newest version of writing this) states that a client can specify a crs query parameter.

Currently this parameter is not passed to the provider as this code shows, so there is no way to support other CRS than WGS84, because it is the default when not specified

In fact pygeoapi seems to break requirement A.2.12 part C which states that HTTP status code 400 should be returned if CRS is unsupported. If CRS is not passed to the provider, there is no way it can fail if CRS is unsupported. In my testing the crs query parameter is completely ignored by pygeoapi for EDR.

Describe the solution you'd like
crs should be passed to the provider as a query argument and should default to either WGS84 or WGS84h depending on if the Z-axis parameter is specified in either in the bbox query argument or z query parameter.

The config should also allow specifying supported CRS for the collection, so requirement A.57 can be adhered to.

So config would look something like:

resources:
  my_collection:
    type: collection
    title: My Collection
    ...
    crs:
     - http://www.opengis.net/def/crs/OGC/1.3/CRS84
     - native

There should also be an exception that can be thrown from a provider that results in an HTTP status code 400. Don't know if this is already supported.

@petergarnaes petergarnaes added the enhancement New feature or request label Jan 15, 2023
Copy link

As per RFC4, this Issue has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Mar 10, 2024
Copy link

As per RFC4, this Issue has been closed due to there being no activity for more than 90 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@sjordan29
Copy link
Contributor

I came across this issue while addressing #1578. This will be important to support datasets in included in your STAC, @dblodgett-usgs -- there are a number of datasets whose primary coordinates are in a projected coordinate reference system rather than WGS84. @aufdenkampe

@tomkralidis, what does the future of adding support for a crs query parameter in EDR (and subsequent CRS transformations) look like? It looks like there is support for transforming features (via the crs_transform decorator) , as well as in the rasterio_.py coverage provider (using pyproj's Transformer.

@tomkralidis tomkralidis added this to the 0.17.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issue marked stale by stale-bot
Projects
None yet
Development

No branches or pull requests

3 participants