-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle reconnects #2
Comments
Has work started to implement this? Is the maximum 2 hours still a limit? |
The 2 hour limit it imposed by AWS. My plan is to have the client monitor the connection status, and upon disconnect (due to connectivity issues or server-side disconnect) attempt to reconnect automatically. I have not started on the implementation of this idea. If you are comfortable with it, feel free to open an PR with your best attempt. |
It would be my pleasure. I currently have a solution working outside of the package, will think it through and get it over in a PR. |
@michaelaguiar @georgeboot did this get implemented yet? |
I implemented it locally but didn’t create the pull request! I’ll make the update and get this PR up likely Monday. I can also provide a solution if you need it sooner. |
@michaelaguiar 🎉 - I'm not in a hurry, we're still in the process of building a POC for using Echo with AWS API Gateway so the 2-hour limit is not going to be a problem at this stage. |
API Gateway websockets, can only live up to maximum 2 hours. The client code should probably automatically reconnect and subscribe to all channels again, when this happens.
The text was updated successfully, but these errors were encountered: