Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowedColPos not working #810

Closed
Domi202 opened this issue Dec 4, 2018 · 1 comment
Closed

allowedColPos not working #810

Domi202 opened this issue Dec 4, 2018 · 1 comment

Comments

@Domi202
Copy link
Contributor

Domi202 commented Dec 4, 2018

Bug Report

Current Behavior
When allowedColPos is set for templateLayouts in PageTSConfig, the layout is not removed if the colPos is not allowed.

Expected behavior/output
If 1.allowedColPos = 1, the layout 1 should not be visible if the content element is in a column other than colPos=1

Environment

  • TYPO3 version(s): 8.7.20
  • news version: 7.0.8
  • Is your TYPO3 installation set up with Composer (Composer Mode): yes
  • OS: Linux 4.9.125-linuxkit

Possible Solution
The method \GeorgRinger\News\Hooks\ItemsProcFunc::reduceTemplateLayouts uses a wrong key to remove restricted layouts from the $allLayouts array (

unset($allLayouts[$restrictedIdentifier]);
).

I will provide a pull request for that soon.

@georgringer
Copy link
Owner

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants