Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading panic in gdal-sys build script #255

Closed
ttencate opened this issue Feb 5, 2022 · 1 comment
Closed

Misleading panic in gdal-sys build script #255

ttencate opened this issue Feb 5, 2022 · 1 comment

Comments

@ttencate
Copy link
Contributor

ttencate commented Feb 5, 2022

This looks dodgy:

gdal/gdal-sys/build.rs

Lines 131 to 136 in 0747fa6

if cfg!(target_env = "msvc") {
panic!("windows-gnu requires gdal_i.lib to be present in either $GDAL_LIB_DIR or $GDAL_HOME\\lib.");
}
// otherwise, look for a gdalxxx.dll in $GDAL_HOME/bin
// works in windows-gnu

I suppose the panic text should say windows-msvc instead of windows-gnu, but for all I know it might be the other way around, which would mean the condition and subsequent comment are wrong.

@lnicola
Copy link
Member

lnicola commented Feb 11, 2023

Fixed in #332.

@lnicola lnicola closed this as completed Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants