-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax restrictions on bool ops between polygon and multipolygon #1205
Conversation
Whereas previously, boolean ops could only be performed between two geometries of the same type, it should now be possible to perform them between any combination of two Polygons and MultiPolygons
@rmanoka I'd love some feedback here to make sure I haven't accidentally tied myself into knots w/r/t/ types – the existing tests weren't modified and all pass, however. The main reason we need this is in order to implement a unary union: a WDYT? |
Would it be clean to implement new traits: So for eg. the |
Yeah I'm open to it – where would that leave the public boolops API? |
Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
I suppose we can deprecate the bool-ops trait, and re-route to the new traits. The method names could probably remain same for ease, and we can provide new alias too. |
I don't think we need this anymore now that #1234 has merged. I think it also enables the major cascaded union use case: https://gist.github.com/urschrei/cd80b4d2ec3c75f12fa541a5bdbf6489 |
I totally forgot about this one. Sorry — we should have merged it months ago. |
Whereas previously, boolean ops could only be performed between two geometries of the same type, it should now be possible to perform them between any combination of two Polygons and MultiPolygons
Closes #1203
CHANGES.md
if knowledge of this change could be valuable to users.