Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more comprehensive parsing examples #86

Closed
urschrei opened this issue Dec 21, 2017 · 0 comments
Closed

Provide more comprehensive parsing examples #86

urschrei opened this issue Dec 21, 2017 · 0 comments

Comments

@urschrei
Copy link
Member

Having just spent a week working with this library, I think we need some more comprehensive examples showing how to use it, and to call out some corner cases. GeoJSON has a relatively simple spec, but there are subtleties that make it tricky to use:

  • FeatureCollections are not straightforward to match against if you want to extract Feature geometries, because they're Option
  • GeometryCollections and the fact that they can nest. Not a big deal in practice because this is discouraged and they're not in wide use anyway, but you have to deal with the possibility
  • Constructing a Feature with properties set to None results in invalid GeoJSON. We should handle this more ergonomically.
  • The try_into trait is available, but not visible in the docs.

To that end, here's #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant