Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when Constellation display format #266

Closed
cokkiy opened this issue Aug 23, 2024 · 1 comment
Closed

Panic when Constellation display format #266

cokkiy opened this issue Aug 23, 2024 · 1 comment

Comments

@cokkiy
Copy link

cokkiy commented Aug 23, 2024

Sample code here:

#[test]
    fn constellation_display_test() {
        let collections = vec![
            Constellation::GPS,
            Constellation::Glonass,
            Constellation::BeiDou,
            Constellation::QZSS,
            Constellation::Galileo,
            Constellation::IRNSS,
            Constellation::WAAS,
            Constellation::EGNOS,
            Constellation::MSAS,
            Constellation::GAGAN,
            Constellation::BDSBAS,
            Constellation::KASS,
            Constellation::SDCM,
            Constellation::ASBAS,
            Constellation::SPAN,
            Constellation::SBAS,
            Constellation::AusNZ,
            Constellation::GBAS,
            Constellation::NSAS,
            Constellation::ASAL,
            Constellation::Mixed,
        ];

        for c in collections {
            println!("{}", c);
        }
    }

This test always panics on println with msg: "a formatting trait implementation returned an error when the underlying stream did not"

@gwbres
Copy link
Collaborator

gwbres commented Aug 24, 2024

Hello @cokkiy,

thank you for picking this up ! the problem was in the formatting method, the SBAS (generic/undefined SBAS) was not covered, while there is no reason it should not.

Reproduced, fixed and merged : rtk-rs/gnss#9

I'm upgrading all branches to this, this will probably take up to one day.
A new release of RINEX is pending, it will be called 0.17.0-alpha

@gwbres gwbres closed this as completed Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants