Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the double transition after change of a value #429

Open
Damianofds opened this issue Jul 16, 2015 · 2 comments
Open

Check the double transition after change of a value #429

Damianofds opened this issue Jul 16, 2015 · 2 comments

Comments

@Damianofds
Copy link
Contributor

country SWE, status. pendingFix -> after any value is changed the activity log reports also a status change (again to PendingFix status).

Investigate why and if this behaviour needs for a fix (maybe we just overlook and forgot something?)

@Damianofds
Copy link
Contributor Author

This behavior seems to exist since a long time ago.

every each save of any question the backend controller invokes the method utils.updateSurveyStatusInProgress(iso3) see here in order to set the status to in_progress if it is the first save ever (so the status was equals to null)

After this commit 7e56855 (see the third file modified) if the status is not null the current status is saved anyway. I can't figure out the reason of this...

This doesn't create any problem to the survey workflow but of course add redundant and misleading entries in the activity log.

@Damianofds
Copy link
Contributor Author

Sure now i remember, this behavior has been introduced in order to keep track of the last contributors action, showed in some report somewhere in the admin area so inconsistent status changes in pending_fix and in_progress will be always showed in the activity log...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant